ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
spark-instrumented-optimizer/core/benchmarks/PropertiesCloneBenchmark-results.txt

41 lines
3.1 KiB
Plaintext
Raw Normal View History

[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
================================================================================================
Properties Cloning
================================================================================================
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
OpenJDK 64-Bit Server VM 1.8.0_222-b10 on Linux 3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
Empty Properties: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
SerializationUtils.clone 0 0 0 0.1 13640.0 1.0X
Utils.cloneProperties 0 0 0 1.6 608.0 22.4X
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
OpenJDK 64-Bit Server VM 1.8.0_222-b10 on Linux 3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
System Properties: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
SerializationUtils.clone 0 0 0 0.0 238968.0 1.0X
Utils.cloneProperties 0 0 0 0.4 2318.0 103.1X
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
OpenJDK 64-Bit Server VM 1.8.0_222-b10 on Linux 3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
Small Properties: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
SerializationUtils.clone 1 1 0 0.0 725849.0 1.0X
Utils.cloneProperties 0 0 0 0.3 2900.0 250.3X
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
OpenJDK 64-Bit Server VM 1.8.0_222-b10 on Linux 3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
Medium Properties: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
SerializationUtils.clone 3 3 0 0.0 2999676.0 1.0X
Utils.cloneProperties 0 0 0 0.1 11734.0 255.6X
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
OpenJDK 64-Bit Server VM 1.8.0_222-b10 on Linux 3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
Large Properties: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11 ### What changes were proposed in this pull request? This PR regenerate the benchmark results in `core` and `mllib` module in order to compare JDK8/JDK11 result. ### Why are the changes needed? According to the result, For `PropertiesCloneBenchmark` and `UDTSerializationBenchmark`, JDK11 is slightly faster. In general, there is no regression in JDK11. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This is a test-only PR. Manually run the benchmark. Closes #25969 from dongjoon-hyun/SPARK-29297. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-30 00:43:58 -04:00
SerializationUtils.clone 6 6 1 0.0 5846410.0 1.0X
Utils.cloneProperties 0 0 0 0.0 22405.0 260.9X
[SPARK-29081][CORE] Replace calls to SerializationUtils.clone on properties with a faster implementation Replace use of `SerializationUtils.clone` with new `Utils.cloneProperties` method Add benchmark + results showing dramatic speed up for effectively equivalent functionality. ### What changes were proposed in this pull request? While I am not sure that SerializationUtils.clone is a performance issue in production, I am sure that it is overkill for the task it is doing (providing a distinct copy of a `Properties` object). This PR provides a benchmark showing the dramatic improvement over the clone operation and replaces uses of `SerializationUtils.clone` on `Properties` with the more specialized `Utils.cloneProperties`. ### Does this PR introduce any user-facing change? Strings are immutable so there is no reason to serialize and deserialize them, it just creates extra garbage. The only functionality that would be changed is the unsupported insertion of non-String objects into the spark local properties. ### How was this patch tested? 1. Pass the Jenkins with the existing tests. 2. Since this is a performance improvement PR, manually run the benchmark. Closes #25787 from databricks-david-lewis/SPARK-29081. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
2019-09-15 03:28:32 -04:00
Reference in a new issue Copy permalink