Style cleanup based on Matei feedback

This commit is contained in:
Patrick Wendell 2013-08-14 14:55:24 -07:00
parent c223176388
commit 04ad78b09d
3 changed files with 4 additions and 5 deletions

View file

@ -130,7 +130,7 @@ private[spark] class Executor(executorId: String, slaveHostname: String, propert
taskStart = System.currentTimeMillis()
val value = task.run(taskId.toInt)
val taskFinish = System.currentTimeMillis()
task.metrics.foreach{ m =>
for (m <- task.metrics) {
m.hostname = Utils.localHostName
m.executorDeserializeTime = (taskStart - startTime).toInt
m.executorRunTime = (taskFinish - taskStart).toInt
@ -158,7 +158,7 @@ private[spark] class Executor(executorId: String, slaveHostname: String, propert
case t: Throwable => {
val serviceTime = (System.currentTimeMillis() - taskStart).toInt
val metrics = attemptedTask.flatMap(t => t.metrics)
metrics.foreach {m =>
for (m <- metrics) {
m.executorRunTime = serviceTime
m.jvmGCTime = getTotalGCTime - startGCTime
}

View file

@ -34,7 +34,6 @@ import spark.scheduler._
import spark.scheduler.cluster._
import spark.scheduler.cluster.SchedulingMode.SchedulingMode
import akka.actor._
import management.ManagementFactory
/**
* A FIFO or Fair TaskScheduler implementation that runs tasks locally in a thread pool. Optionally
@ -218,7 +217,7 @@ private[spark] class LocalScheduler(threads: Int, val maxFailures: Int, val sc:
case t: Throwable => {
val serviceTime = System.currentTimeMillis() - taskStart
val metrics = attemptedTask.flatMap(t => t.metrics)
metrics.foreach {m =>
for (m <- metrics) {
m.executorRunTime = serviceTime.toInt
m.jvmGCTime = getTotalGCTime - startGCTime
}

View file

@ -166,7 +166,7 @@ private[spark] class StagePage(parent: JobProgressUI) {
Utils.memoryBytesToString(s.shuffleBytesWritten)}.getOrElse("")}</td>
}}
<td sorttable_customkey={gcTime.toString}>
{if (gcTime > 0) {parent.formatDuration(gcTime)} else ""}
{if (gcTime > 0) parent.formatDuration(gcTime) else ""}
</td>
<td>{exception.map(e =>
<span>