ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-26081][SQL][FOLLOW-UP] Use foreach instead of misuse of map (for Unit)

Browse source 
## What changes were proposed in this pull request?

This PR proposes to use foreach instead of misuse of map (for Unit). This could cause some weird errors potentially and it's not a good practice anyway. See also SPARK-16694

## How was this patch tested?

N/A

Closes #23341 from HyukjinKwon/followup-SPARK-26081.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This commit is contained in:
Hyukjin Kwon 2018-12-18 20:52:02 +08:00
parent d72571e51d
commit 218341c5db
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
View file

@ -189,5 +189,5 @@ private[csv] class CsvOutputWriter(
gen.write(row)
}
override def close(): Unit = univocityGenerator.map(_.close())
override def close(): Unit = univocityGenerator.foreach(_.close())
}

2
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
View file

@ -190,5 +190,5 @@ private[json] class JsonOutputWriter(
gen.writeLineEnding()
}
override def close(): Unit = jacksonGenerator.map(_.close())
override def close(): Unit = jacksonGenerator.foreach(_.close())
}

4
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
View file

@ -153,7 +153,7 @@ class TextOutputWriter(
private var outputStream: Option[OutputStream] = None
override def write(row: InternalRow): Unit = {
val os = outputStream.getOrElse{
val os = outputStream.getOrElse {
val newStream = CodecStreams.createOutputStream(context, new Path(path))
outputStream = Some(newStream)
newStream
@ -167,6 +167,6 @@ class TextOutputWriter(
}
override def close(): Unit = {
outputStream.map(_.close())
outputStream.foreach(_.close())
}
}