From 32d67d1a93492b1d04b27d34234fcef8188fdacb Mon Sep 17 00:00:00 2001 From: Min Shen Date: Thu, 12 Aug 2021 20:15:09 -0500 Subject: [PATCH] [SPARK-36483][CORE][TESTS] Fix intermittent test failures at Netty 4.1.52+ ### What changes were proposed in this pull request? Fix an intermittent test failure due to Netty dependency version bump. Starting from Netty 4.1.52, its AbstractChannel will throw a new `StacklessClosedChannelException` for channel closed exception. A hardcoded list of Strings to match for channel closed exception in `RPCIntegrationSuite` was not updated, thus leading to the intermittent test failure reported in #33613 ### Why are the changes needed? Fix intermittent test failure ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes #33713 from Victsm/SPARK-36378-followup. Authored-by: Min Shen Signed-off-by: Mridul Muralidharan gmail.com> (cherry picked from commit b8e2186fe13d609a777da9bf68fa31ea38da50fe) Signed-off-by: Mridul Muralidharan --- .../test/java/org/apache/spark/network/RpcIntegrationSuite.java | 1 + 1 file changed, 1 insertion(+) diff --git a/common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java b/common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java index 916c140621..55ccb85698 100644 --- a/common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java +++ b/common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java @@ -383,6 +383,7 @@ public class RpcIntegrationSuite { "closed", "Connection reset", "java.nio.channels.ClosedChannelException", + "io.netty.channel.StacklessClosedChannelException", "java.io.IOException: Broken pipe" ); Set containsAndClosed = Sets.newHashSet(expectedError);