ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

remove unused variable and fix a bug

Browse source
This commit is contained in:
Wang Jianping J 2013-12-20 16:57:24 +08:00
parent da301b57fc
commit 343d8977aa
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
graph/src/main/scala/org/apache/spark/graph/algorithms/Svdpp.scala
View file

@ -21,6 +21,7 @@ class Msg ( // message
object Svdpp {
// implement SVD++ based on http://public.research.att.com/~volinsky/netflix/kdd08koren.pdf
// model (15) on page 6
def run(edges: RDD[Edge[Double]]): Graph[VT, Double] = {
// defalut parameters
@ -91,15 +92,13 @@ object Svdpp {
assert(et.srcAttr != null && et.dstAttr != null)
val usr = et.srcAttr
val itm = et.dstAttr
var p = usr.v1
var q = itm.v1
val itmBias = 0.0
val usrBias = 0.0
val p = usr.v1
val q = itm.v1
var pred = u + usr.bias + itm.bias + q.dotProduct(usr.v2)
pred = math.max(pred, minVal)
pred = math.min(pred, maxVal)
val err = et.attr - pred
val y = (q.mapMultiply(err*usr.norm)).subtract((usr.v2).mapMultiply(gamma7))
val y = (q.mapMultiply(err*usr.norm)).subtract((itm.v2).mapMultiply(gamma7))
val newP = (q.mapMultiply(err)).subtract(p.mapMultiply(gamma7)) // for each connected item q
val newQ = (usr.v2.mapMultiply(err)).subtract(q.mapMultiply(gamma7))
Iterator((et.srcId, new Msg(newP, y, err - gamma6*usr.bias)), (et.dstId, new Msg(newQ, y, err - gamma6*itm.bias)))
@ -135,10 +134,8 @@ object Svdpp {
assert(et.srcAttr != null && et.dstAttr != null)
val usr = et.srcAttr
val itm = et.dstAttr
var p = usr.v1
var q = itm.v1
val itmBias = 0.0
val usrBias = 0.0
val p = usr.v1
val q = itm.v1
var pred = u + usr.bias + itm.bias + q.dotProduct(usr.v2)
pred = math.max(pred, minVal)
pred = math.min(pred, maxVal)