From 4869e437da0d742756eb83329e9fe8f51a825446 Mon Sep 17 00:00:00 2001 From: weixiuli Date: Thu, 20 May 2021 19:03:14 +0900 Subject: [PATCH] [SPARK-35424][SHUFFLE] Remove some useless code in the ExternalBlockHandler ### What changes were proposed in this pull request? Remove some useless code in the ExternalBlockHandler. ### Why are the changes needed? There is some useless code in the ExternalBlockHandler, so we may remove it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exist unittests. Closes #32571 from weixiuli/SPARK-35424. Authored-by: weixiuli Signed-off-by: Hyukjin Kwon --- .../network/shuffle/ExternalBlockHandler.java | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java index 688ee1c01b..09e29cafa9 100644 --- a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java +++ b/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java @@ -42,7 +42,6 @@ import org.apache.spark.network.client.TransportClient; import org.apache.spark.network.server.OneForOneStreamManager; import org.apache.spark.network.server.RpcHandler; import org.apache.spark.network.server.StreamManager; -import org.apache.spark.network.shuffle.ExternalShuffleBlockResolver.AppExecId; import org.apache.spark.network.shuffle.protocol.*; import static org.apache.spark.network.util.NettyUtils.getRemoteAddress; import org.apache.spark.network.util.TransportConf; @@ -242,20 +241,6 @@ public class ExternalBlockHandler extends RpcHandler { blockManager.executorRemoved(executorId, appId); } - /** - * Register an (application, executor) with the given shuffle info. - * - * The "re-" is meant to highlight the intended use of this method -- when this service is - * restarted, this is used to restore the state of executors from before the restart. Normal - * registration will happen via a message handled in receive() - * - * @param appExecId - * @param executorInfo - */ - public void reregisterExecutor(AppExecId appExecId, ExecutorShuffleInfo executorInfo) { - blockManager.registerExecutor(appExecId.appId, appExecId.execId, executorInfo); - } - public void close() { blockManager.close(); }