From 4adbcdc42478b61fa02047d54f3d3705d5b1ecc7 Mon Sep 17 00:00:00 2001 From: "Jungtaek Lim (HeartSaVioR)" Date: Sun, 17 Mar 2019 08:25:40 +0900 Subject: [PATCH] [SPARK-22000][SQL][FOLLOW-UP] Fix bad test to ensure it can test properly ## What changes were proposed in this pull request? There was some mistake on test code: it has wrong assertion. The patch proposes fixing it, as well as fixing other stuff to make test really pass. ## How was this patch tested? Fixed unit test. Closes #24112 from HeartSaVioR/SPARK-22000-hotfix. Authored-by: Jungtaek Lim (HeartSaVioR) Signed-off-by: Takeshi Yamamuro --- .../org/apache/spark/sql/JavaBeanDeserializationSuite.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java b/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java index f59afef36a..c5f38676ad 100644 --- a/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java +++ b/sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java @@ -154,7 +154,7 @@ public class JavaBeanDeserializationSuite implements Serializable { List records = dataset.collectAsList(); - Assert.assertEquals(records, records); + Assert.assertEquals(expectedRecords, records); } @Test @@ -211,7 +211,7 @@ public class JavaBeanDeserializationSuite implements Serializable { record.setDoubleField(String.valueOf(recordRow.getDouble(4))); record.setStringField(recordRow.getString(5)); record.setBooleanField(String.valueOf(recordRow.getBoolean(6))); - record.setTimestampField(String.valueOf(recordRow.getTimestamp(7).getTime() * 1000)); + record.setTimestampField(String.valueOf(recordRow.getTimestamp(7))); // This would figure out that null value will not become "null". record.setNullIntField(null); return record;