ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-35416][K8S][FOLLOWUP] Use Set instead of ArrayBuffer

Browse source 
### What changes were proposed in this pull request?

This is a follow-up of https://github.com/apache/spark/pull/32564 .

### Why are the changes needed?

To use Set instead of ArrayBuffer and add a return type.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #32758 from dongjoon-hyun/SPARK-35416-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
This commit is contained in:
Dongjoon Hyun 2021-06-03 10:41:11 -05:00 committed by Mridul Muralidharan
parent cfde117c6f
commit 4f0db872a0
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
View file

@ -390,8 +390,8 @@ private[spark] class ExecutorPodsAllocator(
private def replacePVCsIfNeeded( private def replacePVCsIfNeeded(
pod: Pod, pod: Pod,
resources: Seq[HasMetadata], resources: Seq[HasMetadata],
reusablePVCs: mutable.Buffer[PersistentVolumeClaim]) = { reusablePVCs: mutable.Buffer[PersistentVolumeClaim]): Seq[HasMetadata] = {
val replacedResources = mutable.ArrayBuffer[HasMetadata]() val replacedResources = mutable.Set[HasMetadata]()
resources.foreach { resources.foreach {
case pvc: PersistentVolumeClaim => case pvc: PersistentVolumeClaim =>
// Find one with the same storage class and size. // Find one with the same storage class and size.
@ -407,7 +407,7 @@ private[spark] class ExecutorPodsAllocator(
} }
if (volume.nonEmpty) { if (volume.nonEmpty) {
val matchedPVC = reusablePVCs.remove(index) val matchedPVC = reusablePVCs.remove(index)
replacedResources.append(pvc) replacedResources.add(pvc)
logInfo(s"Reuse PersistentVolumeClaim ${matchedPVC.getMetadata.getName}") logInfo(s"Reuse PersistentVolumeClaim ${matchedPVC.getMetadata.getName}")
volume.get.getPersistentVolumeClaim.setClaimName(matchedPVC.getMetadata.getName) volume.get.getPersistentVolumeClaim.setClaimName(matchedPVC.getMetadata.getName)
} }