ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.

Browse source 
Both expressions already implement code generation.

Author: Reynold Xin <rxin@databricks.com>

Closes #7723 from rxin/abs-formatnum and squashes the following commits:

31ed765 [Reynold Xin] [SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.
This commit is contained in:
Reynold Xin 2015-07-28 09:42:35 -07:00
parent 4af622c855
commit 5a2330e546
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
View file

@ -68,8 +68,7 @@ case class UnaryPositive(child: Expression) extends UnaryExpression with Expects
@ExpressionDescription(
usage = "_FUNC_(expr) - Returns the absolute value of the numeric value",
extended = "> SELECT _FUNC_('-1');\n1")
case class Abs(child: Expression)
extends UnaryExpression with ExpectsInputTypes with CodegenFallback {
case class Abs(child: Expression) extends UnaryExpression with ExpectsInputTypes {
override def inputTypes: Seq[AbstractDataType] = Seq(NumericType)

2
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
View file

@ -1139,7 +1139,7 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio
* fractional part.
*/
case class FormatNumber(x: Expression, d: Expression)
extends BinaryExpression with ExpectsInputTypes with CodegenFallback {
extends BinaryExpression with ExpectsInputTypes {
override def left: Expression = x
override def right: Expression = d