ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[MINOR][BUILD] Fix current lint-java failures

Browse source 
## What changes were proposed in this pull request?

Fixes current failures in dev/lint-java

## How was this patch tested?

Existing linter, tests.

Author: Sean Owen <sowen@cloudera.com>

Closes #18757 from srowen/LintJava.
This commit is contained in:
Sean Owen 2017-07-28 11:31:40 +01:00
parent a5a3189974
commit 63d168cbb8
3 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
common/network-common/src/test/java/org/apache/spark/network/TransportRequestHandlerSuite.java
View file

@ -105,7 +105,7 @@ public class TransportRequestHandlerSuite {
private List<GenericFutureListener> listeners = new ArrayList<>();
private boolean success;
public ExtendedChannelPromise(Channel channel) {
ExtendedChannelPromise(Channel channel) {
super(channel);
success = false;
}
@ -127,7 +127,9 @@ public class TransportRequestHandlerSuite {
listeners.forEach(listener -> {
try {
listener.operationComplete(this);
} catch (Exception e) { }
} catch (Exception e) {
// do nothing
}
});
}
}

6
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java
View file

@ -120,14 +120,16 @@ final class ShuffleExternalSorter extends MemoryConsumer {
this.taskContext = taskContext;
this.numPartitions = numPartitions;
// Use getSizeAsKb (not bytes) to maintain backwards compatibility if no units are provided
this.fileBufferSizeBytes = (int) (long) conf.get(package$.MODULE$.SHUFFLE_FILE_BUFFER_SIZE()) * 1024;
this.fileBufferSizeBytes =
(int) (long) conf.get(package$.MODULE$.SHUFFLE_FILE_BUFFER_SIZE()) * 1024;
this.numElementsForSpillThreshold =
conf.getLong("spark.shuffle.spill.numElementsForceSpillThreshold", 1024 * 1024 * 1024);
this.writeMetrics = writeMetrics;
this.inMemSorter = new ShuffleInMemorySorter(
this, initialSize, conf.getBoolean("spark.shuffle.sort.useRadixSort", true));
this.peakMemoryUsedBytes = getMemoryUsage();
this.diskWriteBufferSize = (int) (long) conf.get(package$.MODULE$.SHUFFLE_DISK_WRITE_BUFFER_SIZE());
this.diskWriteBufferSize =
(int) (long) conf.get(package$.MODULE$.SHUFFLE_DISK_WRITE_BUFFER_SIZE());
}
/**

2
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ArrowColumnVector.java
View file

@ -322,7 +322,7 @@ public final class ArrowColumnVector extends ReadOnlyColumnVector {
anyNullsSet = numNulls > 0;
}
private static abstract class ArrowVectorAccessor {
private abstract static class ArrowVectorAccessor {
private final ValueVector vector;
private final ValueVector.Accessor nulls;