ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-28686][SQL][TEST] Move udf_radians from HiveCompatibilitySuite to HiveQuerySuite

Browse source 
## What changes were proposed in this pull request?

This PR moves `udf_radians` from `HiveCompatibilitySuite` to `HiveQuerySuite` to make it easy to test with JDK 11 because it returns different value from JDK 9:
```java
public class TestRadians {
  public static void main(String[] args) {
    System.out.println(java.lang.Math.toRadians(57.2958));
  }
}
```
```sh
[rootspark-3267648 ~]# javac TestRadians.java
[rootspark-3267648 ~]# /usr/lib/jdk-9.0.4+11/bin/java TestRadians
1.0000003575641672
[rootspark-3267648 ~]# /usr/lib/jdk-11.0.3/bin/java TestRadians
1.0000003575641672
[rootspark-3267648 ~]# /usr/lib/jdk8u222-b10/bin/java TestRadians
1.000000357564167
```

## How was this patch tested?

manual tests

Closes #25417 from wangyum/SPARK-28686.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This commit is contained in:
Yuming Wang 2019-08-12 02:24:48 -07:00 committed by Dongjoon Hyun
parent 37eedf6149
commit 6c06eea411
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
View file

@ -597,7 +597,9 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
"correlationoptimizer4", "correlationoptimizer4",
"multiMapJoin1", "multiMapJoin1",
"orc_dictionary_threshold", "orc_dictionary_threshold",
"udf_hash" "udf_hash",
// Moved to HiveQuerySuite
"udf_radians"
) )
private def commonWhiteList = Seq( private def commonWhiteList = Seq(
@ -1057,7 +1059,6 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
"udf_positive", "udf_positive",
"udf_pow", "udf_pow",
"udf_power", "udf_power",
"udf_radians",
"udf_rand", "udf_rand",
"udf_regexp", "udf_regexp",
"udf_regexp_extract", "udf_regexp_extract",

17
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file

@ -24,6 +24,7 @@ import java.util.{Locale, TimeZone}
import scala.util.Try import scala.util.Try
import org.apache.commons.lang3.{JavaVersion, SystemUtils}
import org.apache.hadoop.hive.conf.HiveConf.ConfVars import org.apache.hadoop.hive.conf.HiveConf.ConfVars
import org.scalatest.BeforeAndAfter import org.scalatest.BeforeAndAfter
@ -1207,6 +1208,22 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
} }
} }
} }
// This test case is moved from HiveCompatibilitySuite to make it easy to test with JDK 11.
test("udf_radians") {
withSQLConf("hive.fetch.task.conversion" -> "more") {
val result = sql("select radians(57.2958) FROM src tablesample (1 rows)").collect()
if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
assertResult(Array(Row(1.0000003575641672))) (result)
} else {
assertResult(Array(Row(1.000000357564167))) (result)
}
assertResult(Array(Row(2.4999991485811655))) {
sql("select radians(143.2394) FROM src tablesample (1 rows)").collect()
}
}
}
} }
// for SPARK-2180 test // for SPARK-2180 test