ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[MINOR][SQL][TEST] Create table using dataSourceName in HadoopFsRelationTest

Browse source 
## What changes were proposed in this pull request?

This PR fixes a minor issue in `HadoopFsRelationTest`, that you should create table using `dataSourceName` instead of `parquet`. The issue won't affect the correctness, but it will generate wrong error message in case the test fails.

## How was this patch tested?

Exsiting tests.

Author: Xingbo Jiang <xingbo.jiang@databricks.com>

Closes #20780 from jiangxb1987/dataSourceName.
This commit is contained in:
Xingbo Jiang 2018-03-13 23:31:08 +09:00 committed by hyukjinkwon
parent 23370554d0
commit 9ddd1e2cea
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
View file

@ -335,16 +335,17 @@ abstract class HadoopFsRelationTest extends QueryTest with SQLTestUtils with Tes
test("saveAsTable()/load() - non-partitioned table - ErrorIfExists") {
withTable("t") {
sql("CREATE TABLE t(i INT) USING parquet")
intercept[AnalysisException] {
sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
val msg = intercept[AnalysisException] {
testDF.write.format(dataSourceName).mode(SaveMode.ErrorIfExists).saveAsTable("t")
}
}.getMessage
assert(msg.contains("Table `t` already exists"))
}
}
test("saveAsTable()/load() - non-partitioned table - Ignore") {
withTable("t") {
sql("CREATE TABLE t(i INT) USING parquet")
sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
testDF.write.format(dataSourceName).mode(SaveMode.Ignore).saveAsTable("t")
assert(spark.table("t").collect().isEmpty)
}