ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-7976] Add style checker to disallow overriding finalize.

Browse source 
Author: Reynold Xin <rxin@databricks.com>

Closes #6528 from rxin/style-finalizer and squashes the following commits:

a2211ca [Reynold Xin] [SPARK-7976] Enable NoFinalizeChecker.

(cherry picked from commit 084fef76e9)
Signed-off-by: Reynold Xin <rxin@databricks.com>
This commit is contained in:
Reynold Xin 2015-05-30 23:36:32 -07:00
parent 5e268d3956
commit adfc9d1fa0
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
View file

@ -843,6 +843,7 @@ private class PythonAccumulatorParam(@transient serverHost: String, serverPort:
* An Wrapper for Python Broadcast, which is written into disk by Python. It also will * An Wrapper for Python Broadcast, which is written into disk by Python. It also will
* write the data into disk after deserialization, then Python can read it from disks. * write the data into disk after deserialization, then Python can read it from disks.
*/ */
// scalastyle:off no.finalize
private[spark] class PythonBroadcast(@transient var path: String) extends Serializable { private[spark] class PythonBroadcast(@transient var path: String) extends Serializable {
/** /**
@ -884,3 +885,4 @@ private[spark] class PythonBroadcast(@transient var path: String) extends Serial
} }
} }
} }
// scalastyle:on no.finalize

2
scalastyle-config.xml
View file

@ -96,7 +96,7 @@
<!-- <check level="error" class="org.scalastyle.scalariform.ReturnChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.ReturnChecker" enabled="true"></check> -->
<!-- <check level="error" class="org.scalastyle.scalariform.NullChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NullChecker" enabled="true"></check> -->
<!-- <check level="error" class="org.scalastyle.scalariform.NoCloneChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NoCloneChecker" enabled="true"></check> -->
<!-- <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check> --> <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check>
<!-- <check level="error" class="org.scalastyle.scalariform.CovariantEqualsChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.CovariantEqualsChecker" enabled="true"></check> -->
<!-- <check level="error" class="org.scalastyle.scalariform.StructuralTypeChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.StructuralTypeChecker" enabled="true"></check> -->
<!-- <check level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> --> <!-- <check level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> -->