[MINOR][SQL] Spelling: enabled - legacy_setops_precedence_enbled
### What changes were proposed in this pull request?
Replace `legacy_setops_precedence_enbled` with `legacy_setops_precedence_enabled`
Alternatively, `legacy_setops_precedence_enabled` could be added, and `legacy_setops_precedence_enbled` retained, and if set the code could honor it and warn about the deprecated spelling.
### Why are the changes needed?
`enabled` is misspelled in `legacy_setops_precedence_enbled`
### Does this PR introduce _any_ user-facing change?
Yes.
It would break current consumers.
Examples include:
* https://www.programmersought.com/article/87752082924/
* 125d873c38/fugue_sql/_antlr/fugue_sqlLexer.py
* https://github.com/search?q=legacy_setops_precedence_enbled&type=code
### How was this patch tested?
It's been included in #30323 for a while (and is now split out here)
Closes #30677 from jsoref/spelling-enabled.
Authored-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This commit is contained in:
parent
8ac86a4c31
commit
c05f6f98b6
|
@ -21,7 +21,7 @@ grammar SqlBase;
|
|||
* When false, INTERSECT is given the greater precedence over the other set
|
||||
* operations (UNION, EXCEPT and MINUS) as per the SQL standard.
|
||||
*/
|
||||
public boolean legacy_setops_precedence_enbled = false;
|
||||
public boolean legacy_setops_precedence_enabled = false;
|
||||
|
||||
/**
|
||||
* When false, a literal with an exponent would be converted into
|
||||
|
@ -466,11 +466,11 @@ multiInsertQueryBody
|
|||
|
||||
queryTerm
|
||||
: queryPrimary #queryTermDefault
|
||||
| left=queryTerm {legacy_setops_precedence_enbled}?
|
||||
| left=queryTerm {legacy_setops_precedence_enabled}?
|
||||
operator=(INTERSECT | UNION | EXCEPT | SETMINUS) setQuantifier? right=queryTerm #setOperation
|
||||
| left=queryTerm {!legacy_setops_precedence_enbled}?
|
||||
| left=queryTerm {!legacy_setops_precedence_enabled}?
|
||||
operator=INTERSECT setQuantifier? right=queryTerm #setOperation
|
||||
| left=queryTerm {!legacy_setops_precedence_enbled}?
|
||||
| left=queryTerm {!legacy_setops_precedence_enabled}?
|
||||
operator=(UNION | EXCEPT | SETMINUS) setQuantifier? right=queryTerm #setOperation
|
||||
;
|
||||
|
||||
|
|
|
@ -96,7 +96,7 @@ abstract class AbstractSqlParser extends ParserInterface with SQLConfHelper with
|
|||
parser.addParseListener(PostProcessor)
|
||||
parser.removeErrorListeners()
|
||||
parser.addErrorListener(ParseErrorListener)
|
||||
parser.legacy_setops_precedence_enbled = conf.setOpsPrecedenceEnforced
|
||||
parser.legacy_setops_precedence_enabled = conf.setOpsPrecedenceEnforced
|
||||
parser.legacy_exponent_literal_as_decimal_enabled = conf.exponentLiteralAsDecimalEnabled
|
||||
parser.SQL_standard_keyword_behavior = conf.ansiEnabled
|
||||
|
||||
|
|
Loading…
Reference in a new issue