ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint.

Browse source 
Instead of disabling all python style check, we should enable PEP8. So, this PR just comments out the part installing pylint.

Author: Yin Huai <yhuai@databricks.com>

Closes #7704 from yhuai/SPARK-9385 and squashes the following commits:

0056359 [Yin Huai] Enable PEP8 but disable installing pylint.
This commit is contained in:
Yin Huai 2015-07-27 15:49:42 -07:00
parent ab62595661
commit dafe8d857d
2 changed files with 17 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
dev/lint-python
View file

@ -58,21 +58,21 @@ export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
if [ ! -d "$PYLINT_HOME" ]; then
mkdir "$PYLINT_HOME"
# Redirect the annoying pylint installation output.
easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
easy_install_status="$?"
if [ "$easy_install_status" -ne 0 ]; then
echo "Unable to install pylint locally in \"$PYTHONPATH\"."
cat "$PYLINT_INSTALL_INFO"
exit "$easy_install_status"
fi
rm "$PYLINT_INSTALL_INFO"
fi
# if [ ! -d "$PYLINT_HOME" ]; then
# mkdir "$PYLINT_HOME"
# # Redirect the annoying pylint installation output.
# easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
# easy_install_status="$?"
#
# if [ "$easy_install_status" -ne 0 ]; then
# echo "Unable to install pylint locally in \"$PYTHONPATH\"."
# cat "$PYLINT_INSTALL_INFO"
# exit "$easy_install_status"
# fi
#
# rm "$PYLINT_INSTALL_INFO"
#
# fi
# There is no need to write this output to a file
#+ first, but we do so so that the check status can

5
dev/run-tests.py
View file

@ -198,9 +198,8 @@ def run_scala_style_checks():
def run_python_style_checks():
# set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
# run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
pass
set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
def build_spark_documentation():