made SimpleUpdater consistent with other updaters

2013-07-29 22:21:50 -07:00 · 2013-07-29 22:21:50 -07:00 · e4387ddf5d
parent 468a36c005
commit e4387ddf5d
1 changed files with 2 additions and 1 deletions
--- a/mllib/src/main/scala/spark/mllib/optimization/Updater.scala
+++ b/mllib/src/main/scala/spark/mllib/optimization/Updater.scala
@ -41,7 +41,8 @@ abstract class Updater extends Serializable {
 class SimpleUpdater extends Updater {
  override def compute(weightsOld: DoubleMatrix, gradient: DoubleMatrix,
      stepSize: Double, iter: Int, regParam: Double): (DoubleMatrix, Double) = {
-    val normGradient = gradient.mul(stepSize / math.sqrt(iter))
+    val thisIterStepSize = stepSize / math.sqrt(iter)
+    val normGradient = gradient.mul(thisIterStepSize)
    (weightsOld.sub(normGradient), 0)
  }
 }