From e650f8fdbaeb5d9e1fe5729c12d57c4bac4ec169 Mon Sep 17 00:00:00 2001 From: sev7e0 Date: Tue, 24 Sep 2019 14:09:40 -0700 Subject: [PATCH] [SPARK-29230][CORE][TEST] Fix NPE in ProcfsMetricsGetterSuite ### What changes were proposed in this pull request? When I use `ProcfsMetricsGetterSuite for` testing, always throw out `java.lang.NullPointerException`. I think there is a problem with locating `new ProcfsMetricsGetter`, which will lead to `SparkEnv` not being initialized in time. This leads to `java.lang.NullPointerException` when the method is executed. ### Why are the changes needed? For test. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Local testing Closes #25918 from sev7e0/dev_0924. Authored-by: sev7e0 Signed-off-by: Dongjoon Hyun --- .../org/apache/spark/executor/ProcfsMetricsGetterSuite.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala b/core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala index 9ed1497db5..9836697e16 100644 --- a/core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala +++ b/core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala @@ -22,9 +22,9 @@ import org.apache.spark.SparkFunSuite class ProcfsMetricsGetterSuite extends SparkFunSuite { - val p = new ProcfsMetricsGetter(getTestResourcePath("ProcfsMetrics")) test("testGetProcessInfo") { + val p = new ProcfsMetricsGetter(getTestResourcePath("ProcfsMetrics")) var r = ProcfsMetrics(0, 0, 0, 0, 0, 0) r = p.addProcfsMetricsFromOneProcess(r, 26109) assert(r.jvmVmemTotal == 4769947648L)