From ed059541eb3bf2b7bc61c355d8d39b8f7dced5cf Mon Sep 17 00:00:00 2001 From: Angerszhuuuu Date: Wed, 12 May 2021 13:45:53 +0000 Subject: [PATCH] [SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions ### What changes were proposed in this pull request? According to discuss https://github.com/apache/spark/pull/25854#discussion_r629451135 ### Why are the changes needed? Clean code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existed UT Closes #32499 from AngersZhuuuu/SPARK-29145-fix. Authored-by: Angerszhuuuu Signed-off-by: Wenchen Fan --- .../org/apache/spark/sql/catalyst/analysis/Analyzer.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala index 39ddbf1309..18caa05bd5 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala @@ -2352,8 +2352,8 @@ class Analyzer(override val catalogManager: CatalogManager) // Only a few unary nodes (Project/Filter/Aggregate) can contain subqueries. case q: UnaryNode if q.childrenResolved => resolveSubQueries(q, q.children) - case j: Join if j.childrenResolved => - resolveSubQueries(j, Seq(j, j.left, j.right)) + case j: Join if j.childrenResolved && j.duplicateResolved => + resolveSubQueries(j, j.children) case s: SupportsSubquery if s.childrenResolved => resolveSubQueries(s, s.children) }