ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter

Browse source 
### What changes were proposed in this pull request?

This PR is a followup of https://github.com/apache/spark/pull/32436 which broke JavaScript linter. There was a logical conflict - the linter was added after the last successful test run in that PR.

```
added 118 packages in 1.482s

/__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
   34:41  error  'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u  no-unused-vars
   34:47  error  'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u   no-unused-vars
   35:1   error  Expected indentation of 2 spaces but found 4                                      indent
   36:1   error  Expected indentation of 4 spaces but found 7                                      indent
   37:1   error  Expected indentation of 2 spaces but found 4                                      indent
   38:1   error  Expected indentation of 4 spaces but found 7                                      indent
   39:1   error  Expected indentation of 2 spaces but found 4                                      indent
  556:1   error  Expected indentation of 14 spaces but found 16                                    indent
  557:1   error  Expected indentation of 14 spaces but found 16                                    indent
```

### Why are the changes needed?

To recover the build

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested:

```bash
 ./dev/lint-js
lint-js checks passed.
```

Closes #32541 from HyukjinKwon/SPARK-34764-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
This commit is contained in:
Hyukjin Kwon 2021-05-14 12:45:13 +09:00 committed by Kousuke Saruta
parent b6a0a7ea53
commit f7af9ab8dc
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/src/main/resources/org/apache/spark/ui/static/executorspage.js
View file

@ -31,12 +31,12 @@ function getThreadDumpEnabled() {
return threadDumpEnabled;
}
function formatLossReason(removeReason, type, row) {
if (removeReason) {
return removeReason
} else {
return ""
}
function formatLossReason(removeReason) {
if (removeReason) {
return removeReason
} else {
return ""
}
}
function formatStatus(status, type, row) {
@ -553,8 +553,8 @@ $(document).ready(function () {
}
},
{
data: 'removeReason',
render: formatLossReason
data: 'removeReason',
render: formatLossReason
}
],
"order": [[0, "asc"]],