## What changes were proposed in this pull request? revived #13464 Fix Java Lint errors introduced by #13286 and #13280 Before: ``` Using `mvn` from path: /Users/pichu/Project/spark/build/apache-maven-3.3.9/bin/mvn Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0 Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[340,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[341,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[342,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[343,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[41,28] (naming) MethodName: Method name 'Append' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[52,28] (naming) MethodName: Method name 'Complete' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[61,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.PrimitiveType. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[62,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.Type. ``` ## How was this patch tested? ran `dev/lint-java` locally Author: Sandeep Singh <sandeep@techaddict.me> Closes #13559 from techaddict/minor-3.
This commit is contained in:
parent
87706eb66c
commit
f958c1c3e2
|
@ -42,4 +42,6 @@
|
|||
files="src/main/java/org/apache/hive/service/auth/PasswdAuthenticationProvider.java"/>
|
||||
<suppress checks="NoFinalizer"
|
||||
files="src/main/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java"/>
|
||||
<suppress checks="MethodName"
|
||||
files="sql/catalyst/src/main/java/org/apache/spark/sql/streaming/OutputMode.java"/>
|
||||
</suppressions>
|
||||
|
|
|
@ -337,10 +337,10 @@ class LauncherServer implements Closeable {
|
|||
}
|
||||
super.close();
|
||||
if (handle != null) {
|
||||
if (!handle.getState().isFinal()) {
|
||||
LOG.log(Level.WARNING, "Lost connection to spark application.");
|
||||
handle.setState(SparkAppHandle.State.LOST);
|
||||
}
|
||||
if (!handle.getState().isFinal()) {
|
||||
LOG.log(Level.WARNING, "Lost connection to spark application.");
|
||||
handle.setState(SparkAppHandle.State.LOST);
|
||||
}
|
||||
handle.disconnect();
|
||||
}
|
||||
}
|
||||
|
|
|
@ -58,8 +58,6 @@ import org.apache.parquet.hadoop.metadata.BlockMetaData;
|
|||
import org.apache.parquet.hadoop.metadata.ParquetMetadata;
|
||||
import org.apache.parquet.hadoop.util.ConfigurationUtil;
|
||||
import org.apache.parquet.schema.MessageType;
|
||||
import org.apache.parquet.schema.PrimitiveType;
|
||||
import org.apache.parquet.schema.Type;
|
||||
import org.apache.parquet.schema.Types;
|
||||
import org.apache.spark.sql.types.StructType;
|
||||
|
||||
|
|
Loading…
Reference in a new issue