6c4616b2ac
### What changes were proposed in this pull request? This PR removes sbt-avro plugin dependency. In the current master, Build with SBT depends on the plugin but it seems never used. Originally, the plugin was introduced for `flume-sink` in SPARK-1729 (#807) but `flume-sink` is no longer in Spark repository. After SBT was upgraded to 1.x in SPARK-21708 (#29286), `avroGenerate` part was introduced in `object SQL` in `SparkBuild.scala`. It's confusable but I understand `Test / avroGenerate := (Compile / avroGenerate).value` is for suppressing sbt-avro for `sql` sub-module. In fact, Test/compile will fail if `Test / avroGenerate :=(Compile / avroGenerate).value` is commented out. `sql` sub-module contains `parquet-compat.avpr` and `parquet-compat.avdl` but according to `sql/core/src/test/README.md`, they are intended to be handled by `gen-avro.sh`. Also, in terms of Maven build, there seems to be no definition to handle `*.avpr` or `*.avdl`. Based on the above, I think we can remove `sbt-avro`. ### Why are the changes needed? If `sbt-avro` is really no longer used, it's confusable that `sbt-avro` related configurations are in `SparkBuild.scala`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. Closes #33190 from sarutak/remove-avro-from-sbt. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
45 lines
1.7 KiB
Scala
45 lines
1.7 KiB
Scala
/*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright ownership.
|
|
* The ASF licenses this file to You under the Apache License, Version 2.0
|
|
* (the "License"); you may not use this file except in compliance with
|
|
* the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
addSbtPlugin("com.etsy" % "sbt-checkstyle-plugin" % "3.1.1")
|
|
|
|
// sbt-checkstyle-plugin uses an old version of checkstyle. Match it to Maven's.
|
|
libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "8.25"
|
|
|
|
// checkstyle uses guava 23.0.
|
|
libraryDependencies += "com.google.guava" % "guava" % "23.0"
|
|
|
|
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.15.0")
|
|
|
|
addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "5.2.4")
|
|
|
|
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0")
|
|
|
|
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.2")
|
|
|
|
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
|
|
|
|
addSbtPlugin("io.spray" % "sbt-revolver" % "0.9.1")
|
|
|
|
libraryDependencies += "org.ow2.asm" % "asm" % "9.1"
|
|
|
|
libraryDependencies += "org.ow2.asm" % "asm-commons" % "9.1"
|
|
|
|
addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.8.2")
|
|
|
|
addSbtPlugin("com.typesafe.sbt" % "sbt-pom-reader" % "2.2.0")
|