02c91e03f9
## What changes were proposed in this pull request? Currently, we set lintr to jimhester/lintra769c0b (see [this](7d1175011c) and [SPARK-14074](https://issues.apache.org/jira/browse/SPARK-14074)). I first tested and checked lintr-1.0.1 but it looks many important fixes are missing (for example, checking 100 length). So, I instead tried the latest commit,5431140ffe, in my local and fixed the check failures. It looks it has fixed many bugs and now finds many instances that I have observed and thought should be caught time to time, here I filed [the results](https://gist.github.com/HyukjinKwon/4f59ddcc7b6487a02da81800baca533c). The downside looks it now takes about 7ish mins, (it was 2ish mins before) in my local. ## How was this patch tested? Manually, `./dev/lint-r` after manually updating the lintr package. Author: hyukjinkwon <gurwls223@gmail.com> Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes #19290 from HyukjinKwon/upgrade-r-lint.
105 lines
3.8 KiB
R
105 lines
3.8 KiB
R
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
context("binary functions")
|
|
|
|
# JavaSparkContext handle
|
|
sparkSession <- sparkR.session(master = sparkRTestMaster, enableHiveSupport = FALSE)
|
|
sc <- callJStatic("org.apache.spark.sql.api.r.SQLUtils", "getJavaSparkContext", sparkSession)
|
|
|
|
# Data
|
|
nums <- 1:10
|
|
rdd <- parallelize(sc, nums, 2L)
|
|
|
|
# File content
|
|
mockFile <- c("Spark is pretty.", "Spark is awesome.")
|
|
|
|
test_that("union on two RDDs", {
|
|
actual <- collectRDD(unionRDD(rdd, rdd))
|
|
expect_equal(actual, as.list(rep(nums, 2)))
|
|
|
|
fileName <- tempfile(pattern = "spark-test", fileext = ".tmp")
|
|
writeLines(mockFile, fileName)
|
|
|
|
text.rdd <- textFile(sc, fileName)
|
|
union.rdd <- unionRDD(rdd, text.rdd)
|
|
actual <- collectRDD(union.rdd)
|
|
expect_equal(actual, c(as.list(nums), mockFile))
|
|
expect_equal(getSerializedMode(union.rdd), "byte")
|
|
|
|
rdd <- map(text.rdd, function(x) {x})
|
|
union.rdd <- unionRDD(rdd, text.rdd)
|
|
actual <- collectRDD(union.rdd)
|
|
expect_equal(actual, as.list(c(mockFile, mockFile)))
|
|
expect_equal(getSerializedMode(union.rdd), "byte")
|
|
|
|
unlink(fileName)
|
|
})
|
|
|
|
test_that("cogroup on two RDDs", {
|
|
rdd1 <- parallelize(sc, list(list(1, 1), list(2, 4)))
|
|
rdd2 <- parallelize(sc, list(list(1, 2), list(1, 3)))
|
|
cogroup.rdd <- cogroup(rdd1, rdd2, numPartitions = 2L)
|
|
actual <- collectRDD(cogroup.rdd)
|
|
expect_equal(actual,
|
|
list(list(1, list(list(1), list(2, 3))), list(2, list(list(4), list()))))
|
|
|
|
rdd1 <- parallelize(sc, list(list("a", 1), list("a", 4)))
|
|
rdd2 <- parallelize(sc, list(list("b", 2), list("a", 3)))
|
|
cogroup.rdd <- cogroup(rdd1, rdd2, numPartitions = 2L)
|
|
actual <- collectRDD(cogroup.rdd)
|
|
|
|
expected <- list(list("b", list(list(), list(2))), list("a", list(list(1, 4), list(3))))
|
|
expect_equal(sortKeyValueList(actual),
|
|
sortKeyValueList(expected))
|
|
})
|
|
|
|
test_that("zipPartitions() on RDDs", {
|
|
rdd1 <- parallelize(sc, 1:2, 2L) # 1, 2
|
|
rdd2 <- parallelize(sc, 1:4, 2L) # 1:2, 3:4
|
|
rdd3 <- parallelize(sc, 1:6, 2L) # 1:3, 4:6
|
|
actual <- collectRDD(zipPartitions(rdd1, rdd2, rdd3,
|
|
func = function(x, y, z) { list(list(x, y, z))}))
|
|
expect_equal(actual,
|
|
list(list(1, c(1, 2), c(1, 2, 3)), list(2, c(3, 4), c(4, 5, 6))))
|
|
|
|
mockFile <- c("Spark is pretty.", "Spark is awesome.")
|
|
fileName <- tempfile(pattern = "spark-test", fileext = ".tmp")
|
|
writeLines(mockFile, fileName)
|
|
|
|
rdd <- textFile(sc, fileName, 1)
|
|
actual <- collectRDD(zipPartitions(rdd, rdd,
|
|
func = function(x, y) { list(paste(x, y, sep = "\n")) }))
|
|
expected <- list(paste(mockFile, mockFile, sep = "\n"))
|
|
expect_equal(actual, expected)
|
|
|
|
rdd1 <- parallelize(sc, 0:1, 1)
|
|
actual <- collectRDD(zipPartitions(rdd1, rdd,
|
|
func = function(x, y) { list(x + nchar(y)) }))
|
|
expected <- list(0:1 + nchar(mockFile))
|
|
expect_equal(actual, expected)
|
|
|
|
rdd <- map(rdd, function(x) { x })
|
|
actual <- collectRDD(zipPartitions(rdd, rdd1,
|
|
func = function(x, y) { list(y + nchar(x)) }))
|
|
expect_equal(actual, expected)
|
|
|
|
unlink(fileName)
|
|
})
|
|
|
|
sparkR.session.stop()
|