d614967b0b
As described in [SPARK-2627](https://issues.apache.org/jira/browse/SPARK-2627), we'd like Python code to automatically be checked for PEP 8 compliance by Jenkins. This pull request aims to do that. Notes: * We may need to install [`pep8`](https://pypi.python.org/pypi/pep8) on the build server. * I'm expecting tests to fail now that PEP 8 compliance is being checked as part of the build. I'm fine with cleaning up any remaining PEP 8 violations as part of this pull request. * I did not understand why the RAT and scalastyle reports are saved to text files. I did the same for the PEP 8 check, but only so that the console output style can match those for the RAT and scalastyle checks. The PEP 8 report is removed right after the check is complete. * Updates to the ["Contributing to Spark"](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark) guide will be submitted elsewhere, as I don't believe that text is part of the Spark repo. Author: Nicholas Chammas <nicholas.chammas@gmail.com> Author: nchammas <nicholas.chammas@gmail.com> Closes #1744 from nchammas/master and squashes the following commits: 274b238 [Nicholas Chammas] [SPARK-2627] [PySpark] minor indentation changes 983d963 [nchammas] Merge pull request #5 from apache/master 1db5314 [nchammas] Merge pull request #4 from apache/master 0e0245f [Nicholas Chammas] [SPARK-2627] undo erroneous whitespace fixes bf30942 [Nicholas Chammas] [SPARK-2627] PEP8: comment spacing 6db9a44 [nchammas] Merge pull request #3 from apache/master 7b4750e [Nicholas Chammas] merge upstream changes 91b7584 [Nicholas Chammas] [SPARK-2627] undo unnecessary line breaks 44e3e56 [Nicholas Chammas] [SPARK-2627] use tox.ini to exclude files b09fae2 [Nicholas Chammas] don't wrap comments unnecessarily bfb9f9f [Nicholas Chammas] [SPARK-2627] keep up with the PEP 8 fixes 9da347f [nchammas] Merge pull request #2 from apache/master aa5b4b5 [Nicholas Chammas] [SPARK-2627] follow Spark bash style for if blocks d0a83b9 [Nicholas Chammas] [SPARK-2627] check that pep8 downloaded fine dffb5dd [Nicholas Chammas] [SPARK-2627] download pep8 at runtime a1ce7ae [Nicholas Chammas] [SPARK-2627] space out test report sections 21da538 [Nicholas Chammas] [SPARK-2627] it's PEP 8, not PEP8 6f4900b [Nicholas Chammas] [SPARK-2627] more misc PEP 8 fixes fe57ed0 [Nicholas Chammas] removing merge conflict backups 9c01d4c [nchammas] Merge pull request #1 from apache/master 9a66cb0 [Nicholas Chammas] resolving merge conflicts a31ccc4 [Nicholas Chammas] [SPARK-2627] miscellaneous PEP 8 fixes beaa9ac [Nicholas Chammas] [SPARK-2627] fail check on non-zero status 723ed39 [Nicholas Chammas] always delete the report file 0541ebb [Nicholas Chammas] [SPARK-2627] call Python linter from run-tests 12440fa [Nicholas Chammas] [SPARK-2627] add Scala linter 61c07b9 [Nicholas Chammas] [SPARK-2627] add Python linter 75ad552 [Nicholas Chammas] make check output style consistent
112 lines
4.2 KiB
Bash
Executable file
112 lines
4.2 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
# Go to the Spark project root directory
|
|
FWDIR="$(cd `dirname $0`/..; pwd)"
|
|
cd "$FWDIR"
|
|
|
|
if [ -n "$AMPLAB_JENKINS_BUILD_PROFILE" ]; then
|
|
if [ "$AMPLAB_JENKINS_BUILD_PROFILE" = "hadoop1.0" ]; then
|
|
export SBT_MAVEN_PROFILES_ARGS="-Dhadoop.version=1.0.4"
|
|
elif [ "$AMPLAB_JENKINS_BUILD_PROFILE" = "hadoop2.0" ]; then
|
|
export SBT_MAVEN_PROFILES_ARGS="-Dhadoop.version=2.0.0-mr1-cdh4.1.1"
|
|
elif [ "$AMPLAB_JENKINS_BUILD_PROFILE" = "hadoop2.2" ]; then
|
|
export SBT_MAVEN_PROFILES_ARGS="-Pyarn -Dhadoop.version=2.2.0"
|
|
elif [ "$AMPLAB_JENKINS_BUILD_PROFILE" = "hadoop2.3" ]; then
|
|
export SBT_MAVEN_PROFILES_ARGS="-Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0"
|
|
fi
|
|
fi
|
|
|
|
if [ -z "$SBT_MAVEN_PROFILES_ARGS" ]; then
|
|
export SBT_MAVEN_PROFILES_ARGS="-Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0"
|
|
fi
|
|
|
|
export SBT_MAVEN_PROFILES_ARGS="$SBT_MAVEN_PROFILES_ARGS -Pkinesis-asl"
|
|
|
|
echo "SBT_MAVEN_PROFILES_ARGS=\"$SBT_MAVEN_PROFILES_ARGS\""
|
|
|
|
# Remove work directory
|
|
rm -rf ./work
|
|
|
|
if test -x "$JAVA_HOME/bin/java"; then
|
|
declare java_cmd="$JAVA_HOME/bin/java"
|
|
else
|
|
declare java_cmd=java
|
|
fi
|
|
JAVA_VERSION=$($java_cmd -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
|
|
[ "$JAVA_VERSION" -ge 18 ] && echo "" || echo "[Warn] Java 8 tests will not run because JDK version is < 1.8."
|
|
|
|
# Partial solution for SPARK-1455. Only run Hive tests if there are sql changes.
|
|
if [ -n "$AMPLAB_JENKINS" ]; then
|
|
git fetch origin master:master
|
|
diffs=`git diff --name-only master | grep "^sql/"`
|
|
if [ -n "$diffs" ]; then
|
|
echo "Detected changes in SQL. Will run Hive test suite."
|
|
export _RUN_SQL_TESTS=true # exported for PySpark tests
|
|
fi
|
|
fi
|
|
|
|
# Fail fast
|
|
set -e
|
|
set -o pipefail
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Running Apache RAT checks"
|
|
echo "========================================================================="
|
|
dev/check-license
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Running Scala style checks"
|
|
echo "========================================================================="
|
|
dev/lint-scala
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Running Python style checks"
|
|
echo "========================================================================="
|
|
dev/lint-python
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Running Spark unit tests"
|
|
echo "========================================================================="
|
|
|
|
if [ -n "$_RUN_SQL_TESTS" ]; then
|
|
SBT_MAVEN_PROFILES_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-thriftserver"
|
|
fi
|
|
# echo "q" is needed because sbt on encountering a build file with failure
|
|
# (either resolution or compilation) prompts the user for input either q, r,
|
|
# etc to quit or retry. This echo is there to make it not block.
|
|
echo -e "q\n" | sbt/sbt $SBT_MAVEN_PROFILES_ARGS clean package assembly/assembly test | \
|
|
grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Running PySpark tests"
|
|
echo "========================================================================="
|
|
./python/run-tests
|
|
|
|
echo ""
|
|
echo "========================================================================="
|
|
echo "Detecting binary incompatibilites with MiMa"
|
|
echo "========================================================================="
|
|
dev/mima
|