519e03d82e
## What changes were proposed in this pull request? We should use `Block.isEmpty/nonEmpty` instead of comparing with empty string to check whether the code is empty or not. ``` [error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala:278: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely always compare unequal [error] [warn] if (ev.code != "" && required.contains(attributes(i))) { [error] [warn] [error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala:323: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely never compare equal [error] [warn] | ${buildVars.filter(_.code == "").map(v => s"${v.isNull} = true;").mkString("\n")} [error] [warn] ``` ## How was this patch tested? Existing tests. Closes #22041 from ueshin/issues/SPARK-25058/fix_comparison. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Takuya UESHIN <ueshin@databricks.com> |
||
---|---|---|
.. | ||
benchmarks | ||
src | ||
pom.xml |