5e120e4651
### What changes were proposed in this pull request? The `change-scala-version.sh` script updates Scala versions across the build for cross-build purposes. It manually changes `scala.binary.version` but not `scala.version`. ### Why are the changes needed? It seems that this has always been an oversight, and the cross-built builds of Spark have an incorrect scala.version. See 2.4.5's 2.12 POM for example, which shows a Scala 2.11 version. https://search.maven.org/artifact/org.apache.spark/spark-core_2.12/2.4.5/pom More comments in the JIRA. ### Does this PR introduce _any_ user-facing change? Should be a build-only bug fix. ### How was this patch tested? Existing tests, but really N/A Closes #31801 from srowen/SPARK-34507. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
82 lines
2.7 KiB
Bash
Executable file
82 lines
2.7 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
set -e
|
|
|
|
VALID_VERSIONS=( 2.12 2.13 )
|
|
|
|
usage() {
|
|
echo "Usage: $(basename $0) [-h|--help] <version>
|
|
where :
|
|
-h| --help Display this help text
|
|
valid version values : ${VALID_VERSIONS[*]}
|
|
" 1>&2
|
|
exit 1
|
|
}
|
|
|
|
if [[ ($# -ne 1) || ( $1 == "--help") || $1 == "-h" ]]; then
|
|
usage
|
|
fi
|
|
|
|
TO_VERSION=$1
|
|
|
|
check_scala_version() {
|
|
for i in ${VALID_VERSIONS[*]}; do [ $i = "$1" ] && return 0; done
|
|
echo "Invalid Scala version: $1. Valid versions: ${VALID_VERSIONS[*]}" 1>&2
|
|
exit 1
|
|
}
|
|
|
|
check_scala_version "$TO_VERSION"
|
|
|
|
if [ $TO_VERSION = "2.13" ]; then
|
|
FROM_VERSION="2.12"
|
|
else
|
|
FROM_VERSION="2.13"
|
|
fi
|
|
|
|
sed_i() {
|
|
sed -e "$1" "$2" > "$2.tmp" && mv "$2.tmp" "$2"
|
|
}
|
|
|
|
export -f sed_i
|
|
|
|
BASEDIR=$(dirname $0)/..
|
|
find "$BASEDIR" -name 'pom.xml' -not -path '*target*' -print \
|
|
-exec bash -c "sed_i 's/\(artifactId.*\)_'$FROM_VERSION'/\1_'$TO_VERSION'/g' {}" \;
|
|
|
|
# Update <scala.version> in parent POM
|
|
# First find the right full version from the profile's build
|
|
SCALA_VERSION=`build/mvn help:evaluate -Pscala-${TO_VERSION} -Dexpression=scala.version -q -DforceStdout`
|
|
sed_i '1,/<scala\.version>[0-9]*\.[0-9]*\.[0-9]*</s/<scala\.version>[0-9]*\.[0-9]*\.[0-9]*</<scala.version>'$SCALA_VERSION'</' \
|
|
"$BASEDIR/pom.xml"
|
|
|
|
# Also update <scala.binary.version> in parent POM
|
|
# Match any scala binary version to ensure idempotency
|
|
sed_i '1,/<scala\.binary\.version>[0-9]*\.[0-9]*</s/<scala\.binary\.version>[0-9]*\.[0-9]*</<scala.binary.version>'$TO_VERSION'</' \
|
|
"$BASEDIR/pom.xml"
|
|
|
|
# Update source of scaladocs
|
|
echo "$BASEDIR/docs/_plugins/copy_api_dirs.rb"
|
|
if [ $TO_VERSION = "2.13" ]; then
|
|
sed_i '/\-Pscala-'$TO_VERSION'/!s:build/sbt:build/sbt \-Pscala\-'$TO_VERSION':' "$BASEDIR/docs/_plugins/copy_api_dirs.rb"
|
|
else
|
|
sed_i 's:build/sbt \-Pscala\-'$FROM_VERSION':build/sbt:' "$BASEDIR/docs/_plugins/copy_api_dirs.rb"
|
|
fi
|
|
sed_i 's/scala\-'$FROM_VERSION'/scala\-'$TO_VERSION'/' "$BASEDIR/docs/_plugins/copy_api_dirs.rb"
|