6252c54e39
**What changes were proposed in this pull request?** Moving the call for checkColumnNameDuplication out of generateViewProperties. This way we can choose ifcheckColumnNameDuplication will be performed on analyzed or aliased plan without having to pass an additional argument(aliasedPlan) to generateViewProperties. Before the pr column name duplication was performed on the query output of below sql(c1, c1) and the pr makes it perform check on the user provided schema of view definition(c1, c2) **Why are the changes needed?** Changes are to fix SPARK-23519 bug. Below queries would cause an exception. This pr fixes them and also added a test case. `CREATE TABLE t23519 AS SELECT 1 AS c1 CREATE VIEW v23519 (c1, c2) AS SELECT c1, c1 FROM t23519` **Does this PR introduce any user-facing change?** No **How was this patch tested?** new unit test added in SQLViewSuite Closes #25570 from hem1891/SPARK-23519. Lead-authored-by: hemanth meka <hmeka@tibco.com> Co-authored-by: hem1891 <hem1891@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> |
||
|---|---|---|
| .. | ||
| benchmarks | ||
| src | ||
| v1.2.1/src | ||
| v2.3.5/src | ||
| pom.xml | ||