Apache Spark - A unified analytics engine for large-scale data processing
Go to file
Juliusz Sompolski 7539ae59d6 [SPARK-23366] Improve hot reading path in ReadAheadInputStream
## What changes were proposed in this pull request?

`ReadAheadInputStream` was introduced in https://github.com/apache/spark/pull/18317/ to optimize reading spill files from disk.
However, from the profiles it seems that the hot path of reading small amounts of data (like readInt) is inefficient - it involves taking locks, and multiple checks.

Optimize locking: Lock is not needed when simply accessing the active buffer. Only lock when needing to swap buffers or trigger async reading, or get information about the async state.

Optimize short-path single byte reads, that are used e.g. by Java library DataInputStream.readInt.

The asyncReader used to call "read" only once on the underlying stream, that never filled the underlying buffer when it was wrapping an LZ4BlockInputStream. If the buffer was returned unfilled, that would trigger the async reader to be triggered to fill the read ahead buffer on each call, because the reader would see that the active buffer is below the refill threshold all the time.

However, filling the full buffer all the time could introduce increased latency, so also add an `AtomicBoolean` flag for the async reader to return earlier if there is a reader waiting for data.

Remove `readAheadThresholdInBytes` and instead immediately trigger async read when switching the buffers. It allows to simplify code paths, especially the hot one that then only has to check if there is available data in the active buffer, without worrying if it needs to retrigger async read. It seems to have positive effect on perf.

## How was this patch tested?

It was noticed as a regression in some workloads after upgrading to Spark 2.3. 

It was particularly visible on TPCDS Q95 running on instances with fast disk (i3 AWS instances).
Running with profiling:
* Spark 2.2 - 5.2-5.3 minutes 9.5% in LZ4BlockInputStream.read
* Spark 2.3 - 6.4-6.6 minutes 31.1% in ReadAheadInputStream.read
* Spark 2.3 + fix - 5.3-5.4 minutes 13.3% in ReadAheadInputStream.read - very slightly slower, practically within noise.

We didn't see other regressions, and many workloads in general seem to be faster with Spark 2.3 (not investigated if thanks to async readed, or unrelated).

Author: Juliusz Sompolski <julek@databricks.com>

Closes #20555 from juliuszsompolski/SPARK-23366.
2018-02-15 17:09:06 +08:00
.github [SPARK-18073][DOCS][WIP] Migrate wiki to spark.apache.org web site 2016-11-23 11:25:47 +00:00
assembly [SPARK-23028] Bump master branch version to 2.4.0-SNAPSHOT 2018-01-13 00:37:59 +08:00
bin [SPARK-22994][K8S] Use a single image for all Spark containers. 2018-01-11 10:37:35 -08:00
build [SPARK-19810][BUILD][CORE] Remove support for Scala 2.10 2017-07-13 17:06:24 +08:00
common [SPARK-21860][CORE][FOLLOWUP] fix java style error 2018-02-09 08:46:27 -06:00
conf [SPARK-22466][SPARK SUBMIT] export SPARK_CONF_DIR while conf is default 2017-11-09 14:33:08 +09:00
core [SPARK-23366] Improve hot reading path in ReadAheadInputStream 2018-02-15 17:09:06 +08:00
data [SPARK-23205][ML] Update ImageSchema.readImages to correctly set alpha values for four-channel images 2018-01-25 18:15:29 -06:00
dev [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.7.1 2018-02-08 12:52:08 -06:00
docs [SPARK-23421][SPARK-22356][SQL] Document the behavior change in 2018-02-14 23:52:59 -08:00
examples [MINOR][DOC] Use raw triple double quotes around docstrings where there are occurrences of backslashes. 2018-02-03 10:31:04 -08:00
external Revert "[SPARK-23303][SQL] improve the explain result for data source v2 relations" 2018-02-13 16:21:17 -08:00
graphx [SPARK-23028] Bump master branch version to 2.4.0-SNAPSHOT 2018-01-13 00:37:59 +08:00
hadoop-cloud [SPARK-23028] Bump master branch version to 2.4.0-SNAPSHOT 2018-01-13 00:37:59 +08:00
launcher [SPARK-23020][CORE] Fix another race in the in-process launcher test. 2018-02-02 11:43:22 +08:00
licenses [SPARK-19112][CORE] Support for ZStandard codec 2017-11-01 14:54:08 +01:00
mllib [SPARK-23217][ML] Add cosine distance measure to ClusteringEvaluator 2018-02-13 11:51:19 -06:00
mllib-local [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sparse 2018-01-19 09:28:35 -06:00
project [SPARK-20659][CORE] Removing sc.getExecutorStorageStatus and making StorageStatus private 2018-02-13 06:54:15 -08:00
python [SPARK-20090][FOLLOW-UP] Revert the deprecation of names in PySpark 2018-02-13 15:05:13 +09:00
R [SPARK-23327][SQL] Update the description and tests of three external API or functions 2018-02-06 16:46:43 -08:00
repl [SPARK-20659][CORE] Removing sc.getExecutorStorageStatus and making StorageStatus private 2018-02-13 06:54:15 -08:00
resource-managers [SPARK-16501][MESOS] Allow providing Mesos principal & secret via files 2018-02-09 11:23:06 -08:00
sbin [SPARK-22994][K8S] Use a single image for all Spark containers. 2018-01-11 10:37:35 -08:00
sql [SPARK-23419][SPARK-23416][SS] data source v2 write path should re-throw interruption exceptions directly 2018-02-15 16:59:44 +08:00
streaming [SPARK-23382][WEB-UI] Spark Streaming ui about the contents of the for need to have hidden and show features, when the table records very much. 2018-02-13 11:39:33 -06:00
tools [SPARK-23028] Bump master branch version to 2.4.0-SNAPSHOT 2018-01-13 00:37:59 +08:00
.gitattributes [SPARK-3870] EOL character enforcement 2014-10-31 12:39:52 -07:00
.gitignore [SPARK-7721][PYTHON][TESTS] Adds PySpark coverage generation script 2018-01-22 22:12:50 +09:00
.travis.yml [SPARK-18278][SCHEDULER] Spark on Kubernetes - Basic Scheduler Backend 2017-11-28 23:02:09 -08:00
appveyor.yml [SPARK-22817][R] Use fixed testthat version for SparkR tests in AppVeyor 2017-12-17 14:40:41 +09:00
CONTRIBUTING.md [SPARK-18073][DOCS][WIP] Migrate wiki to spark.apache.org web site 2016-11-23 11:25:47 +00:00
LICENSE [SPARK-19112][CORE] Support for ZStandard codec 2017-11-01 14:54:08 +01:00
NOTICE [SPARK-18278][SCHEDULER] Spark on Kubernetes - Basic Scheduler Backend 2017-11-28 23:02:09 -08:00
pom.xml [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.7.1 2018-02-08 12:52:08 -06:00
README.md [MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown 2017-04-03 10:09:11 +01:00
scalastyle-config.xml [SPARK-20657][CORE] Speed up rendering of the stages page. 2018-01-11 19:41:48 +08:00

Apache Spark

Spark is a fast and general cluster computing system for Big Data. It provides high-level APIs in Scala, Java, Python, and R, and an optimized engine that supports general computation graphs for data analysis. It also supports a rich set of higher-level tools including Spark SQL for SQL and DataFrames, MLlib for machine learning, GraphX for graph processing, and Spark Streaming for stream processing.

http://spark.apache.org/

Online Documentation

You can find the latest Spark documentation, including a programming guide, on the project web page. This README file only contains basic setup instructions.

Building Spark

Spark is built using Apache Maven. To build Spark and its example programs, run:

build/mvn -DskipTests clean package

(You do not need to do this if you downloaded a pre-built package.)

You can build Spark using more than one thread by using the -T option with Maven, see "Parallel builds in Maven 3". More detailed documentation is available from the project site, at "Building Spark".

For general development tips, including info on developing Spark using an IDE, see "Useful Developer Tools".

Interactive Scala Shell

The easiest way to start using Spark is through the Scala shell:

./bin/spark-shell

Try the following command, which should return 1000:

scala> sc.parallelize(1 to 1000).count()

Interactive Python Shell

Alternatively, if you prefer Python, you can use the Python shell:

./bin/pyspark

And run the following command, which should also return 1000:

>>> sc.parallelize(range(1000)).count()

Example Programs

Spark also comes with several sample programs in the examples directory. To run one of them, use ./bin/run-example <class> [params]. For example:

./bin/run-example SparkPi

will run the Pi example locally.

You can set the MASTER environment variable when running examples to submit examples to a cluster. This can be a mesos:// or spark:// URL, "yarn" to run on YARN, and "local" to run locally with one thread, or "local[N]" to run locally with N threads. You can also use an abbreviated class name if the class is in the examples package. For instance:

MASTER=spark://host:7077 ./bin/run-example SparkPi

Many of the example programs print usage help if no params are given.

Running Tests

Testing first requires building Spark. Once Spark is built, tests can be run using:

./dev/run-tests

Please see the guidance on how to run tests for a module, or individual tests.

A Note About Hadoop Versions

Spark uses the Hadoop core library to talk to HDFS and other Hadoop-supported storage systems. Because the protocols have changed in different versions of Hadoop, you must build Spark against the same version that your cluster runs.

Please refer to the build documentation at "Specifying the Hadoop Version" for detailed guidance on building for a particular distribution of Hadoop, including building for particular Hive and Hive Thriftserver distributions.

Configuration

Please refer to the Configuration Guide in the online documentation for an overview on how to configure Spark.

Contributing

Please review the Contribution to Spark guide for information on how to get started contributing to the project.