02c91e03f9
## What changes were proposed in this pull request? Currently, we set lintr to jimhester/lintra769c0b (see [this](7d1175011c) and [SPARK-14074](https://issues.apache.org/jira/browse/SPARK-14074)). I first tested and checked lintr-1.0.1 but it looks many important fixes are missing (for example, checking 100 length). So, I instead tried the latest commit,5431140ffe, in my local and fixed the check failures. It looks it has fixed many bugs and now finds many instances that I have observed and thought should be caught time to time, here I filed [the results](https://gist.github.com/HyukjinKwon/4f59ddcc7b6487a02da81800baca533c). The downside looks it now takes about 7ish mins, (it was 2ish mins before) in my local. ## How was this patch tested? Manually, `./dev/lint-r` after manually updating the lintr package. Author: hyukjinkwon <gurwls223@gmail.com> Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes #19290 from HyukjinKwon/upgrade-r-lint.
38 lines
1.5 KiB
R
38 lines
1.5 KiB
R
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
argv <- commandArgs(TRUE)
|
|
SPARK_ROOT_DIR <- as.character(argv[1])
|
|
LOCAL_LIB_LOC <- file.path(SPARK_ROOT_DIR, "R", "lib")
|
|
|
|
# Checks if SparkR is installed in a local directory.
|
|
if (! library(SparkR, lib.loc = LOCAL_LIB_LOC, logical.return = TRUE)) {
|
|
stop("You should install SparkR in a local directory with `R/install-dev.sh`.")
|
|
}
|
|
|
|
# Installs lintr from Github in a local directory.
|
|
# NOTE: The CRAN's version is too old to adapt to our rules.
|
|
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
|
|
devtools::install_github("jimhester/lintr@5431140")
|
|
}
|
|
|
|
library(lintr)
|
|
library(methods)
|
|
library(testthat)
|
|
path.to.package <- file.path(SPARK_ROOT_DIR, "R", "pkg")
|
|
lint_package(path.to.package, cache = FALSE)
|