1f90c5e219
JoshRosen we'd like to check the SparkR source code with the `dev/lint-r` script on the Jenkins. I tried to incorporate the script into `dev/run-test.py`. Could you review it when you have time? shivaram I modified `dev/lint-r` and `dev/lint-r.R` to install lintr package into a local directory(`R/lib/`) and to exit with a lint status. Could you review it? - [[SPARK-8505] Add settings to kick `lint-r` from `./dev/run-test.py` - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8505) Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com> Closes #7883 from yu-iskw/SPARK-8505.
38 lines
1.5 KiB
R
38 lines
1.5 KiB
R
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
argv <- commandArgs(TRUE)
|
|
SPARK_ROOT_DIR <- as.character(argv[1])
|
|
LOCAL_LIB_LOC <- file.path(SPARK_ROOT_DIR, "R", "lib")
|
|
|
|
# Checks if SparkR is installed in a local directory.
|
|
if (! library(SparkR, lib.loc = LOCAL_LIB_LOC, logical.return = TRUE)) {
|
|
stop("You should install SparkR in a local directory with `R/install-dev.sh`.")
|
|
}
|
|
|
|
# Installs lintr from Github in a local directory.
|
|
# NOTE: The CRAN's version is too old to adapt to our rules.
|
|
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
|
|
devtools::install_github("jimhester/lintr")
|
|
}
|
|
|
|
library(lintr)
|
|
library(methods)
|
|
library(testthat)
|
|
path.to.package <- file.path(SPARK_ROOT_DIR, "R", "pkg")
|
|
lint_package(path.to.package, cache = FALSE)
|