8b119f1663
### What changes were proposed in this pull request? This PR reverts https://github.com/apache/spark/pull/27860 to downgrade Janino, as the new version has a bug. ### Why are the changes needed? The symptom is about NaN comparison. For code below ``` if (double_value <= 0.0) { ... } else { ... } ``` If `double_value` is NaN, `NaN <= 0.0` is false and we should go to the else branch. However, current Spark goes to the if branch and causes correctness issues like SPARK-32640. One way to fix it is: ``` boolean cond = double_value <= 0.0; if (cond) { ... } else { ... } ``` I'm not familiar with Janino so I don't know what's going on there. ### Does this PR introduce _any_ user-facing change? Yes, fix correctness bugs. ### How was this patch tested? a new test Closes #29495 from cloud-fan/revert. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> |
||
---|---|---|
.. | ||
spark-deps-hadoop-2.7-hive-1.2 | ||
spark-deps-hadoop-2.7-hive-2.3 | ||
spark-deps-hadoop-3.2-hive-2.3 |