f6356f9bc0
## What changes were proposed in this pull request? Alter View can excute sql like "ALTER VIEW ... AS INSERT INTO" . We should throw ParseException(s"Operation not allowed: $message", ctx) as Create View does. ``` override def visitCreateView(ctx: CreateViewContext): LogicalPlan = withOrigin(ctx) { if (ctx.identifierList != null) { operationNotAllowed("CREATE VIEW ... PARTITIONED ON", ctx) } else { // CREATE VIEW ... AS INSERT INTO is not allowed. ctx.query.queryNoWith match { case s: SingleInsertQueryContext if s.insertInto != null => operationNotAllowed("CREATE VIEW ... AS INSERT INTO", ctx) case _: MultiInsertQueryContext => operationNotAllowed("CREATE VIEW ... AS FROM ... [INSERT INTO ...]+", ctx) case _ => // OK } ``` ``` override def visitAlterViewQuery(ctx: AlterViewQueryContext): LogicalPlan = withOrigin(ctx) { // ALTER VIEW ... AS INSERT INTO is not allowed. ctx.query.queryNoWith match { case s: SingleInsertQueryContext if s.insertInto != null => operationNotAllowed("ALTER VIEW ... AS INSERT INTO", ctx) case _: MultiInsertQueryContext => operationNotAllowed("ALTER VIEW ... AS FROM ... [INSERT INTO ...]+", ctx) case _ => // OK } AlterViewAsCommand( name = visitTableIdentifier(ctx.tableIdentifier), originalText = source(ctx.query), query = plan(ctx.query)) } ``` ## How was this patch tested? UT has been added in SparkSqlParserSuite Closes #22028 from sddyljsx/SPARK-25046. Lead-authored-by: Neal Song <neal_song@126.com> Co-authored-by: neal <neal_song@126.com> Signed-off-by: Xiao Li <gatorsmile@gmail.com> |
||
---|---|---|
.. | ||
benchmarks | ||
src | ||
pom.xml |