ODIn/spark-instrumented-optimizer
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SPARK-36483][CORE][TESTS] Fix intermittent test failures at Netty 4.1.52+

Browse source 
### What changes were proposed in this pull request?

Fix an intermittent test failure due to Netty dependency version bump.
Starting from Netty 4.1.52, its AbstractChannel will throw a new `StacklessClosedChannelException` for channel closed exception.
A hardcoded list of Strings to match for channel closed exception in `RPCIntegrationSuite` was not updated, thus leading to the intermittent test failure reported in #33613

### Why are the changes needed?

Fix intermittent test failure

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Closes #33713 from Victsm/SPARK-36378-followup.

Authored-by: Min Shen <mshen@linkedin.com>
Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
(cherry picked from commit b8e2186fe1)
Signed-off-by: Mridul Muralidharan <mridulatgmail.com>
This commit is contained in:
Min Shen 2021-08-12 20:15:09 -05:00 committed by Mridul Muralidharan
parent 3785738838
commit 32d67d1a93
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
View file

@ -383,6 +383,7 @@ public class RpcIntegrationSuite {
"closed", "closed",
"Connection reset", "Connection reset",
"java.nio.channels.ClosedChannelException", "java.nio.channels.ClosedChannelException",
"io.netty.channel.StacklessClosedChannelException",
"java.io.IOException: Broken pipe" "java.io.IOException: Broken pipe"
); );
Set<String> containsAndClosed = Sets.newHashSet(expectedError); Set<String> containsAndClosed = Sets.newHashSet(expectedError);